On ti, 2016-08-09 at 15:52 +0300, Ville Syrjälä wrote: > On Tue, Aug 09, 2016 at 02:34:10PM +0300, Imre Deak wrote: > > Similarly to the previous patch, initialize the PPS from the DP > > encoder's resume hook. Note that as opposed to LVDS we can't do this > > during encoder enabling, since we need the PPS for DP detection as well. > > > > Signed-off-by: Imre Deak <[email protected]> > > --- > > drivers/gpu/drm/i915/intel_dp.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c > > b/drivers/gpu/drm/i915/intel_dp.c > > index 4796ad7..76f5b72 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -4665,6 +4665,9 @@ void intel_dp_encoder_reset(struct drm_encoder > > *encoder) > > */ > > if (IS_VALLEYVIEW(encoder->dev) || IS_CHERRYVIEW(encoder->dev)) > > vlv_initial_power_sequencer_setup(intel_dp); > > + else > > + intel_dp_init_panel_power_sequencer_registers(encoder->dev, > > + intel_dp); > > This is almosts the same code as we have in intel_edp_init_connector(), > excep not calling intel_dp_init_panel_power_sequencer() for !VLV/CHV. > > intel_dp_init_panel_power_sequencer() should be safe to call multiple > times since it checks if things were already initialized, and we already > call it here for VLV/CHV. So I think we should just be able share the > code for init and resume?
Ok, can factor these out to a new helper. Btw, would it make sense to call intel_dp_init_panel_power_sequencer_registers() from intel_dp_init_panel_power() directly, they are not called separately any more. > > > > > intel_edp_panel_vdd_sanitize(intel_dp); > > > > -- > > 2.5.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > [email protected] > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
