On Tue, 26 Apr 2016, Daniel Vetter <[email protected]> wrote: > On Tue, Apr 26, 2016 at 01:27:39PM +0300, Jani Nikula wrote: >> Only support NC GPIOs for now, and assume the vlv gpio table only has NC >> GPIOs for now. > > What is an "NC"? I think at least the commit message should explain that, > maybe even the code ...
The specs refer to both North Complex and Cluster. I updated the commit message while pushing... but somehow managed to write North Core in there. *facepalm*. -EDECAF. Anyway it's just geography, and CHV has intercardinal directions as well. BR, Jani. > -Daniel > >> >> Signed-off-by: Jani Nikula <[email protected]> >> --- >> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c >> b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c >> index c7281c391d0f..a1cc8533cff5 100644 >> --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c >> +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c >> @@ -203,8 +203,8 @@ static void vlv_exec_gpio(struct drm_i915_private >> *dev_priv, >> map = &vlv_gpio_table[gpio_index]; >> >> if (dev_priv->vbt.dsi.seq_version >= 3) { >> - DRM_DEBUG_KMS("GPIO element v3 not supported\n"); >> - return; >> + /* XXX: this assumes vlv_gpio_table only has NC GPIOs. */ >> + port = IOSF_PORT_GPIO_NC; >> } else { >> if (gpio_source == 0) { >> port = IOSF_PORT_GPIO_NC; >> -- >> 2.1.4 >> >> _______________________________________________ >> Intel-gfx mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
