On Fri, Apr 22, 2016 at 02:25:07PM +0300, Joonas Lahtinen wrote: > Move graphics stolen memory related early quirk into a function to > allow easy adding of other graphics quirks to fix memory maps on > machines running old BIOS versions. > > While at it; > - _funcs -> _ops to follow de facto naming > - make the iteration code tad more readable > - remove unused variables > > Cc: Chris Wilson <[email protected]> > Cc: Mika Kuoppala <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Cc: Tvrtko Ursulin <[email protected]> > Signed-off-by: Joonas Lahtinen <[email protected]>
Mechanical again, and less quirky, Reserved-by: Chris Wilson <[email protected]> > -static void __init intel_graphics_stolen(int num, int slot, int func) > +static void __init > +intel_graphics_stolen(int num, int slot, int func, > + const struct intel_early_ops *early_ops) > { > + phys_addr_t base; > size_t size; > + > + size = early_ops->stolen_size(num, slot, func); > + base = early_ops->stolen_base(num, slot, func, size); > + > + if (!size || !base) > + return; if (size + base < base) return; Just in case? Hmm, not sure if the integer sizes will always be suitable for the test, so probably just trust the hardware registers? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
