On Mon, 18 Apr 2016, Chris Wilson <[email protected]> wrote: > [ text/plain ] > On Mon, Apr 18, 2016 at 06:09:28PM +0300, Joonas Lahtinen wrote: >> @@ -251,7 +245,7 @@ static int swsci(struct drm_device *dev, u32 function, >> u32 parm, u32 *parm_out) >> struct drm_i915_private *dev_priv = dev->dev_private; >> struct opregion_swsci *swsci = dev_priv->opregion.swsci; >> u32 main_function, sub_function, scic; >> - u16 pci_swsci; >> + u16 swsci_reg; > > This threw me. In other places _reg means the register offset and _val > means the value we want to poke into the register.
IMO you could just leave it as pci_swsci. BR, Jani. > > Happy with everything else. > -Chris -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
