On Mon, 11 Apr 2016 14:43:39 +0100
Lionel Landwerlin <[email protected]> wrote:

> Color management properties are a bit of an odd use case because
> they're not marked as atomic properties. Currently we're not updating
> the non atomic values so the drm_crtc_state is out of sync with the
> values stored in the crtc object.
> 
> v2: Update non atomic values only if commit succeeds (Bob Paauwe)
> 
> v3: Do not access crtc_state after commit, use crtc->state (Maarten
>     Lankhorst)
> 

Reviewed-by: Bob Paauwe <[email protected]>
Tested-by; Bob Paauwe <[email protected]>

> Cc: Maarten Lankhorst <[email protected]>
> Cc: Bob Paauwe <[email protected]>
> Cc: <[email protected]>
> Signed-off-by: Lionel Landwerlin <[email protected]>
> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c 
> b/drivers/gpu/drm/drm_atomic_helper.c
> index 7bf678e..13b86cf 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -2979,6 +2979,14 @@ retry:
>       if (ret)
>               goto fail;
>  
> +     drm_object_property_set_value(&crtc->base,
> +                     config->degamma_lut_property, 0);
> +     drm_object_property_set_value(&crtc->base,
> +                     config->ctm_property, 0);
> +     drm_object_property_set_value(&crtc->base,
> +                     config->gamma_lut_property,
> +                     crtc->state->gamma_lut->base.id);
> +
>       /* Driver takes ownership of state on successful commit. */
>  
>       drm_property_unreference_blob(blob);



-- 
--
Bob Paauwe                  
[email protected]
IOTG / PED Software Organization
Intel Corp.  Folsom, CA
(916) 356-6193    

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to