On Tue, Mar 22, 2016 at 09:02:17AM +0000, Peter Antoine wrote:
> Chris.
> 
> Can these patches be reviewed without the tests or are they blocked
> waiting for the tests.

More or less waiting upon the tests. Or where is the bugzilla?

It would only take a couple of hours to write something like:

for_each_engine() {
        switch (mode) {
        case NOTHING: break;
        case RESET: reset_gpu(); break;
        case SUSPEND: suspend_autoresume(); brea;
        case HIBERNATE: hibernate_autoresume(); brea;
        }
        fd = drm_open_driver();
        if (use_context)
                ctx = gem_context_create();
        for_each_mocs()
                MI_STORE_REGISTER_MEM(engine, mocs, out[i]);
        execbuf(engine)

        gem_set_domain(out, DOMAIN_COU, 0);
        /* Check ABI caching levels */
        for_each_mocs()
                igt_assert(out[i], foo);
        close(fd);
}

> Are the patches acceptable?

Yes, with a reference to a bug demonstrating the impact and a testcase
to demonstrate it works.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to