On Mon, Dec 14, 2015 at 05:01:45PM +0000, Chris Wilson wrote: > On Mon, Dec 14, 2015 at 06:23:40PM +0200, [email protected] wrote: > > From: Ville Syrjälä <[email protected]> > > > > When a partial ggtt vma gets evicted, we need to zap any CPU > > mapping to said vma as well. Currently we zap the mappings > > only when the normal gtt vma gets evicted, but for partial > > vmas we leave behind stale CPU mappins. And so, if something > > else gets bound into the same gtt address range, any > > userspace access into the relevant virtual addresses will > > go astray. > > > > I didn't find anything really suitable in the mm code to zap > > just the needed mappings (we'd need to know the right CPU > > side mm and vma etc.), so let's just call i915_gem_release_mmap() > > for now. > > > > Cc: Joonas Lahtinen <[email protected]> > > Cc: Tvrtko Ursulin <[email protected]> > > Cc: Chris Wilson <[email protected]> > > Testcase: igt/gem_mmap_gtt > > Fixes: c5ad54c ("drm/i915: Use partial view in mmap fault handler") > > Signed-off-by: Ville Syrjälä <[email protected]> > > I fixed this by tracking vma->map_and_fenceable instead. We still kill > the entire object though. Note this is not enough to completely fix the > test case, so perhaps we wait until we can merge the series to do the > full fix?
Sure, if you have something better in the pipeline I'm happy to drop this. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
