On ke, 2015-11-11 at 13:37 -0800, Bob Paauwe wrote:
> Since commit
> 
>   commit aed242ff7ebb697e4dff912bd4dc7ec7192f7581
>   Author: Chris Wilson <[email protected]>
>   Date:   Wed Mar 18 09:48:21 2015 +0000
> 
>       drm/i915: Relax RPS contraints to allows setting minfreq on
> idle
> 
> it is now possible that the current frequency will drop below the
> user
> specified minimum frequency. Update the pm_rps tests to reflect that
> this is no longer considered a failure.
> 
> Signed-off-by: Bob Paauwe <[email protected]>

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89728

Bob could you send an updated version of this patch?

> ---
>  tests/pm_rps.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/pm_rps.c b/tests/pm_rps.c
> index 74f08f4..e92ca3b 100644
> --- a/tests/pm_rps.c
> +++ b/tests/pm_rps.c
> @@ -146,7 +146,6 @@ static void checkit(const int *freqs)
>  {
>       igt_assert_lte(freqs[MIN], freqs[MAX]);
>       igt_assert_lte(freqs[CUR], freqs[MAX]);
> -     igt_assert_lte(freqs[MIN], freqs[CUR]);
>       igt_assert_lte(freqs[RPn], freqs[MIN]);
>       igt_assert_lte(freqs[MAX], freqs[RP0]);
>       igt_assert_lte(freqs[RP1], freqs[RP0]);
> @@ -472,14 +471,14 @@ static void idle_check(void)
>               read_freqs(freqs);
>               dump(freqs);
>               checkit(freqs);
> -             if (freqs[CUR] == freqs[MIN])
> +             if (freqs[CUR] <= freqs[MIN])
>                       break;
>               usleep(1000 * IDLE_WAIT_TIMESTEP_MSEC);
>               wait += IDLE_WAIT_TIMESTEP_MSEC;
>       } while (wait < IDLE_WAIT_TIMEOUT_MSEC);
>  
> -     igt_assert_eq(freqs[CUR], freqs[MIN]);
> -     igt_debug("Required %d msec to reach cur=min\n", wait);
> +     igt_assert_lte(freqs[CUR], freqs[MIN]);
> +     igt_debug("Required %d msec to reach cur<=min\n", wait);
>  }
>  
>  #define LOADED_WAIT_TIMESTEP_MSEC 100
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to