On to, 2015-09-17 at 14:20 +0100, Damien Lespiau wrote: > Not the first time! not the last time? > > There is a possibility to use gcc 5's -Wbool-compare to try and compare > (reg) in those macros to a constant and gcc will warn that the > comparison between a boolean expression and a constant is always either > true or false. Maybe. > > Cc: Imre Deak <[email protected]> > Signed-off-by: Damien Lespiau <[email protected]>
Errrr. Thanks for catching it: Reviewed-by: Imre Deak <[email protected]> > --- > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > b/drivers/gpu/drm/i915/intel_ddi.c > index 4823184..5b600bf 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -2882,7 +2882,7 @@ static bool bxt_ddi_pll_get_hw_state(struct > drm_i915_private *dev_priv, > * here just read out lanes 0/1 and output a note if lanes 2/3 differ. > */ > hw_state->pcsdw12 = I915_READ(BXT_PORT_PCS_DW12_LN01(port)); > - if (I915_READ(BXT_PORT_PCS_DW12_LN23(port) != hw_state->pcsdw12)) > + if (I915_READ(BXT_PORT_PCS_DW12_LN23(port)) != hw_state->pcsdw12) > DRM_DEBUG_DRIVER("lane stagger config different for lane 01 > (%08x) and 23 (%08x)\n", > hw_state->pcsdw12, > I915_READ(BXT_PORT_PCS_DW12_LN23(port))); _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
