On ke, 2015-05-27 at 10:52 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <[email protected]> > > Printing it for PPGTT VMAs only adds noise since we have defined > view types are only applicable for GGTT. > > Signed-off-by: Tvrtko Ursulin <[email protected]> > Cc: Joonas Lahtinen <[email protected]>
Comment below. Reviewed-by: Joonas Lahtinen <[email protected]> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c > b/drivers/gpu/drm/i915/i915_debugfs.c > index fece922..9d36be8 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -156,13 +156,13 @@ describe_obj(struct seq_file *m, struct > drm_i915_gem_object *obj) > if (obj->fence_reg != I915_FENCE_REG_NONE) > seq_printf(m, " (fence: %d)", obj->fence_reg); > list_for_each_entry(vma, &obj->vma_list, vma_link) { > - if (!i915_is_ggtt(vma->vm)) > - seq_puts(m, " (pp"); > + seq_printf(m, " (%sgtt offset: %08llx, size: %08llx", > + i915_is_ggtt(vma->vm) ? "g" : "pp", > + vma->node.start, vma->node.size); > + if (i915_is_ggtt(vma->vm)) > + seq_printf(m, ", type: %u)", vma->ggtt_view.type); The amount of minimalism is quite high here, but it was already before the patch. Splitting full words is not of my preference, because it makes grepping for them harder for example when you trace the output text back to generating code. Regards, Joonas > else > - seq_puts(m, " (g"); > - seq_printf(m, "gtt offset: %08llx, size: %08llx, type: %u)", > - vma->node.start, vma->node.size, > - vma->ggtt_view.type); > + seq_puts(m, ")"); > } > if (obj->stolen) > seq_printf(m, " (stolen: %08llx)", obj->stolen->start); _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
