On Thu, Sep 11, 2014 at 12:51:37PM +0100, John Harrison wrote: > Will the PPGTT fix be sent out soon? If not, can you just send me a quick > fix directly?
I was hoping to gather some feedback before the next send. Patch incorporated into http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=requests&id=982e529754f5da90fe2d243633dfb2daf2ae2e7b > Also, noticed that in 'submit_execbuf()', if the 'copy_from_user()' call > fails then it jumps to the error return but does not set 'ret' thus will > actually return success. Also, there seems to be a mix of 'goto error' vs > 'return E*'. In general it looks like you do the goto only after 'rq' has > been allocated but there are a couple of places that do the jump with a > null 'rq'. The code will cope with trying to put a null rq but it seems a > bit inconsistent. Thanks, went with a single return. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
