On Wed, Jun 18, 2014 at 12:32:00PM +0100, Damien Lespiau wrote: > On Wed, Jun 18, 2014 at 02:27:27PM +0530, [email protected] wrote: > > From: Sonika Jindal <[email protected]> > > > > Testcase for 180 degree HW rotation > > > > Cc: [email protected] > > > > Signed-off-by: Sonika Jindal <[email protected]> > > The test looks good to me (I haven't checked in details, the bar for igt > is quite a bit lower). It shows two gaps in the igt kms API: > > - Retrieving the primary plane (there's a series from Matt fixing this > and exposing the primary plane through igt_output_get_plane()) > - Adding a set_property() convenience function > (ala igt_plane_set_property("rotation", BIT(DRM_ROTATE_180))) > (no-one is working on that just yet, can de done later) > > A small question before pushing this, have you checked that the test > correctly skips when running with a kernel without rotation support?
Note: don't push userspace using new ABI until that ABI has been agreed upon and committed to the kernel. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
