Re: [v3,5/7] drm: writeback: Modify params for drm_writeback_get_out_fence

[John Harrison]

On 3/16/26 01:30, Suraj Kandpal wrote:
Use drm_connector instead of drm_writeback_connector since it now
resides within drm_connector and also helps make sure
drm_wrtieback_connector is being modified mostly by drm core
provided helpers.
And yet another way of saying the same thing. As per other patches, keep 
the description consistent across the entire set.


Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
---
  drivers/gpu/drm/drm_atomic_uapi.c | 4 +---
  drivers/gpu/drm/drm_writeback.c   | 6 +++---
  include/drm/drm_writeback.h       | 2 +-
  3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c 
b/drivers/gpu/drm/drm_atomic_uapi.c
index 13576a6c25d7..5e61565c939b 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -1446,7 +1446,6 @@ static int prepare_signaling(struct drm_device *dev,
        }
  
  	for_each_new_connector_in_state(state, conn, conn_state, i) {
-               struct drm_writeback_connector *wb_conn;
                struct drm_out_fence_state *f;
                struct dma_fence *fence;
                s32 __user *fence_ptr;
@@ -1468,8 +1467,7 @@ static int prepare_signaling(struct drm_device *dev,
                f[*num_fences].out_fence_ptr = fence_ptr;
                *fence_state = f;
  
-		wb_conn = &conn->writeback;
-               fence = drm_writeback_get_out_fence(wb_conn);
+               fence = drm_writeback_get_out_fence(conn);
                if (!fence)
                        return -ENOMEM;
  
diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
index f3b4371d4201..15a680ba98ae 100644
--- a/drivers/gpu/drm/drm_writeback.c
+++ b/drivers/gpu/drm/drm_writeback.c
@@ -528,11 +528,11 @@ drm_writeback_signal_completion(struct drm_connector 
*connector,
  EXPORT_SYMBOL(drm_writeback_signal_completion);
  
  struct dma_fence *
-drm_writeback_get_out_fence(struct drm_writeback_connector *wb_connector)
+drm_writeback_get_out_fence(struct drm_connector *connector)
  {
        struct dma_fence *fence;
-       struct drm_connector *connector =
-               drm_writeback_to_connector(wb_connector);
+       struct drm_writeback_connector *wb_connector =
+               &connector->writeback;
Does this need to be line wrapped?

John.

  
  	if (WARN_ON(connector->connector_type !=
                    DRM_MODE_CONNECTOR_WRITEBACK))
diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
index 5e8ab51c2da4..2afa48ea7c00 100644
--- a/include/drm/drm_writeback.h
+++ b/include/drm/drm_writeback.h
@@ -104,5 +104,5 @@ drm_writeback_signal_completion(struct drm_connector 
*connector,
                                int status);
  
  struct dma_fence *
-drm_writeback_get_out_fence(struct drm_writeback_connector *wb_connector);
+drm_writeback_get_out_fence(struct drm_connector *connector);
  #endif