On Tue, 09 Sep 2025, Ville Syrjälä <[email protected]> wrote: > On Tue, Aug 19, 2025 at 03:53:30PM +0300, Jani Nikula wrote: >> Rebase and resend of [1]. >> >> [1] https://lore.kernel.org/r/[email protected] >> >> Jani Nikula (12): >> drm/i915: add vlv_clock_get_gpll() >> drm/i915: add vlv_clock_get_czclk() >> drm/i915: add vlv_clock_get_hrawclk() >> drm/i915: make vlv_get_cck_clock_hpll() static >> drm/i915: add vlv_clock_get_cdclk() >> drm/i915: make vlv_get_cck_clock() static >> drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco() >> drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it >> more >> drm/i915: remove intel_update_czclk() as unnecessary >> drm/i915: log HPLL frequency similar to CZCLK >> drm/i915: move hpll and czclk caching under display >> drm/i915: split out vlv_clock.[ch] >> >> drivers/gpu/drm/i915/Makefile | 1 + >> drivers/gpu/drm/i915/display/intel_cdclk.c | 29 ++---- >> drivers/gpu/drm/i915/display/intel_display.c | 61 ------------- >> drivers/gpu/drm/i915/display/intel_display.h | 6 -- >> .../gpu/drm/i915/display/intel_display_core.h | 5 ++ >> .../drm/i915/display/intel_display_driver.c | 1 - >> drivers/gpu/drm/i915/display/vlv_clock.c | 89 +++++++++++++++++++ >> drivers/gpu/drm/i915/display/vlv_clock.h | 38 ++++++++ > > Ideally that should live in soc/ > > I think we could even link it separately to both i915 and > the (eventual) display module since they don't actually > need to share anything (apart from the sideband mailbox > interface). Would avoid having to add anything for this > stuff into the inter module interface.
Superficially soc/ is obvious, but it has been a bit of a problem area for sharing between drivers. For example, what to do with platform detection code there? Or MMIO? > And as mentioned in the reply to one of the patches the > vlv_iosf_sb_get/put() stuff is now quite messy. So that > probably needs another cleanup pass to make the interface > actually sensible. Judging by the CI results, I guess we need that pass before merging. Ugh. > I guess all of that could be done/thought about later though, > so for now the series is: > Acked-by: Ville Syrjälä <[email protected]> Thanks, need to still track that problem before merging. BR, Jani. > >> drivers/gpu/drm/i915/gt/intel_rc6.c | 3 +- >> drivers/gpu/drm/i915/gt/intel_rps.c | 11 ++- >> drivers/gpu/drm/i915/i915_drv.h | 3 - >> drivers/gpu/drm/xe/xe_device_types.h | 6 -- >> 12 files changed, 148 insertions(+), 105 deletions(-) >> create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.c >> create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.h >> >> -- >> 2.47.2 -- Jani Nikula, Intel
