On 2025-08-29 14:37:55 [+0200], Maarten Lankhorst wrote:
> Hey,
Hi,
>
> That requires adding new macros for 23 tracepoints for something that only
> affects preempt-rt,
> and even then only on a specific type of uncommon output (DSI).
Sure. I just wanted to mention this but if it is not worth it, drop it.
I am totally fine with the proposal here btw.
> Aren't we also completely duplicating the functionality of tracepoints then?
Depends. You would have the static branch twice but the trace macro does
a bit more. You wouldn't be the "first" user of this either:
| if (trace_amdgpu_dm_brightness_enabled()) {
| trace_amdgpu_dm_brightness(__builtin_return_address(0),
| user_brightness,
| brightness,
| caps->aux_support,
| power_supply_is_system_supplied()
> 0);
| }
My memory is also that Steven suggested something like this (using the
_enabled macro) among with some macros for trace point generation but I
can't find these emails anymore. So I have no proof and could make
things up…
> Kind regards,
> ~maarten Lankhorst
Sebastian