RE: [PATCH] drm/i915/vblank: Change log from err to debug

Sun, 27 Jul 2025 23:17:16 -0700 


> -----Original Message-----
> From: Intel-gfx <[email protected]> On Behalf Of Suraj
> Kandpal
> Sent: 24 July 2025 16:00
> To: [email protected]; [email protected]
> Cc: Nautiyal, Ankit K <[email protected]>; Kandpal, Suraj
> <[email protected]>
> Subject: [PATCH] drm/i915/vblank: Change log from err to debug
> 
> Let Potential update error just be a long instead of an big error we already 
> have

I think some typos to address in commit message, otherwise change is straight 
forward and looks good.

Please update before merge. 

Code changes LGTM.
Reviewed-by: Mitul Golani <[email protected]>

> Atomic Update error log which shouts out if something really goes wrong.
> 
> Signed-off-by: Suraj Kandpal <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_vblank.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c
> b/drivers/gpu/drm/i915/display/intel_vblank.c
> index 70ba7aa26bf4..3e51deca0c21 100644
> --- a/drivers/gpu/drm/i915/display/intel_vblank.c
> +++ b/drivers/gpu/drm/i915/display/intel_vblank.c
> @@ -724,9 +724,9 @@ int intel_vblank_evade(struct intel_vblank_evade_ctx
> *evade)
>                       break;
> 
>               if (!timeout) {
> -                     drm_err(display->drm,
> -                             "Potential atomic update failure on pipe
> %c\n",
> -                             pipe_name(crtc->pipe));
> +                     drm_dbg_kms(display->drm,
> +                                 "Potential atomic update failure on pipe
> %c\n",
> +                                 pipe_name(crtc->pipe));
>                       break;
>               }
> 
> --
> 2.34.1























					Reply via email to