== Series Details == Series: drm/i915: refactor VLV IOSF SB for display usage URL : https://patchwork.freedesktop.org/series/148266/ State : warning
== Summary == Error: dim checkpatch failed 8d12bc3f7133 drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch] -:236: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #236: rename from drivers/gpu/drm/i915/vlv_sideband.c total: 0 errors, 1 warnings, 0 checks, 207 lines checked 6acb4974bc81 drm/i915: add generic read/write functions for VLV IOSF SB -:70: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #70: FILE: drivers/gpu/drm/i915/vlv_iosf_sb.c:177: + if (drm_WARN_ONCE(&i915->drm, !port, "invalid unit %d\n", unit)) + return 0; -:71: WARNING:TABSTOP: Statements should start on a tabstop #71: FILE: drivers/gpu/drm/i915/vlv_iosf_sb.c:178: + return 0; -:86: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #86: FILE: drivers/gpu/drm/i915/vlv_iosf_sb.c:193: + if (drm_WARN_ONCE(&i915->drm, !port, "invalid unit %d\n", unit)) + return -EINVAL; -:87: WARNING:TABSTOP: Statements should start on a tabstop #87: FILE: drivers/gpu/drm/i915/vlv_iosf_sb.c:194: + return -EINVAL; -:146: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #146: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:31: +static inline u32 vlv_iosf_sb_read(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr) -:146: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #146: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:31: } +static inline u32 vlv_iosf_sb_read(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr) -:152: WARNING:LONG_LINE: line length of 113 exceeds 100 columns #152: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:35: +static inline int vlv_iosf_sb_write(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr, u32 val) -:152: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #152: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:35: } +static inline int vlv_iosf_sb_write(struct drm_i915_private *i915, enum vlv_iosf_sb_unit unit, u32 addr, u32 val) total: 0 errors, 6 warnings, 2 checks, 130 lines checked f09031009bae drm/i915: rewrite VLV IOSF SB unit specific read/write functions 5ed15ac4a69c drm/i915: switch i915 core to generic VLV IOSF SB functions 2d9a25d9d985 drm/i915: move VLV IOSF SB unit specific helpers under display -:162: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #162: new file mode 100644 -:307: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #307: FILE: drivers/gpu/drm/i915/display/vlv_sideband.h:90: +} +static inline void vlv_dpio_write(struct drm_i915_private *i915, total: 0 errors, 1 warnings, 1 checks, 599 lines checked df2a8542e9a7 drm/i915: convert VLV IOSF SB interface to struct drm_device -:1827: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #1827: FILE: drivers/gpu/drm/i915/display/vlv_sideband.h:90: } +static inline void vlv_dpio_write(struct drm_device *drm, -:2252: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #2252: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:30: } +static inline u32 vlv_iosf_sb_read(struct drm_device *drm, enum vlv_iosf_sb_unit unit, u32 addr) -:2257: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #2257: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:34: +static inline int vlv_iosf_sb_write(struct drm_device *drm, enum vlv_iosf_sb_unit unit, u32 addr, u32 val) -:2257: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #2257: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:34: } +static inline int vlv_iosf_sb_write(struct drm_device *drm, enum vlv_iosf_sb_unit unit, u32 addr, u32 val) -:2262: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #2262: FILE: drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h:38: } +static inline void vlv_iosf_sb_put(struct drm_device *drm, unsigned long ports) total: 0 errors, 1 warnings, 4 checks, 2084 lines checked
