On Tue, Oct 29, 2024 at 04:41:29PM +0200, Jani Nikula wrote:
> On Tue, 29 Oct 2024, Mika Kahola <mika.kah...@intel.com> wrote:

...

> > +static void wa_14020908590(struct intel_display *display,
> > +                      bool enable)
> > +{
> > +   bool error = false;
> > +
> > +   /* check if mailbox is running busy */
> > +   if (intel_de_wait_for_clear(display, TCSS_DISP_MAILBOX_IN_CMD,
> > +                               TCSS_DISP_MAILBOX_IN_CMD_RUN_BUSY, 10)) {
> > +           drm_dbg_kms(display->drm,
> > +                       "Timeout waiting for TCSS mailbox run/busy bit to 
> > clear\n");
> 
> Just do drm_WARN() with the message here.

Rather,

        ret = intel_de_wait_for_clear();
        if (drm_WARN(drm, ret, ...))
                return;

Cleaner?

Raag

Reply via email to