On Tue, Jun 04, 2024 at 06:26:21PM +0300, Jani Nikula wrote: > Avoid the implicit dev_priv local variable use, and pass dev_priv > explicitly to the TRANS_MSA_MISC register macro.
Reviewed-by: Rodrigo Vivi <[email protected]> > > Signed-off-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 3 ++- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index 368cd1312d8a..327f748d3774 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -440,7 +440,8 @@ void intel_ddi_set_dp_msa(const struct intel_crtc_state > *crtc_state, > if (intel_dp_needs_vsc_sdp(crtc_state, conn_state)) > temp |= DP_MSA_MISC_COLOR_VSC_SDP; > > - intel_de_write(dev_priv, TRANS_MSA_MISC(cpu_transcoder), temp); > + intel_de_write(dev_priv, TRANS_MSA_MISC(dev_priv, cpu_transcoder), > + temp); > } > > static u32 bdw_trans_port_sync_master_select(enum transcoder > master_transcoder) > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 3de6e4f54bc0..3fcebccb9f3c 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -4229,7 +4229,7 @@ enum skl_power_gate { > #define _TRANSB_MSA_MISC 0x61410 > #define _TRANSC_MSA_MISC 0x62410 > #define _TRANS_EDP_MSA_MISC 0x6f410 > -#define TRANS_MSA_MISC(tran) _MMIO_TRANS2(dev_priv, tran, _TRANSA_MSA_MISC) > +#define TRANS_MSA_MISC(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran, > _TRANSA_MSA_MISC) > /* See DP_MSA_MISC_* for the bit definitions */ > > #define _TRANS_A_SET_CONTEXT_LATENCY 0x6007C > -- > 2.39.2 >
