On Tue, Jun 04, 2024 at 06:25:38PM +0300, Jani Nikula wrote: > Avoid the implicit dev_priv local variable use, and pass dev_priv > explicitly to the PIPEFRAME register macro.
Reviewed-by: Rodrigo Vivi <[email protected]> > > Signed-off-by: Jani Nikula <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_vblank.c | 3 ++- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c > b/drivers/gpu/drm/i915/display/intel_vblank.c > index e2d20064e68d..ac8ad3ebf4a4 100644 > --- a/drivers/gpu/drm/i915/display/intel_vblank.c > +++ b/drivers/gpu/drm/i915/display/intel_vblank.c > @@ -102,7 +102,8 @@ u32 i915_get_vblank_counter(struct drm_crtc *crtc) > * we get a low value that's stable across two reads of the high > * register. > */ > - frame = intel_de_read64_2x32(dev_priv, PIPEFRAMEPIXEL(pipe), > PIPEFRAME(pipe)); > + frame = intel_de_read64_2x32(dev_priv, PIPEFRAMEPIXEL(pipe), > + PIPEFRAME(dev_priv, pipe)); > > pixel = frame & PIPE_PIXEL_MASK; > frame = (frame >> PIPE_FRAME_LOW_SHIFT) & 0xffffff; > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index fbd004bd1992..c4f8c50f61d4 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -1878,7 +1878,7 @@ > > #define TRANSCONF(dev_priv, trans) _MMIO_PIPE2(dev_priv, (trans), > _TRANSACONF) > #define PIPEDSL(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, > _PIPEADSL) > -#define PIPEFRAME(pipe) _MMIO_PIPE2(dev_priv, pipe, > _PIPEAFRAMEHIGH) > +#define PIPEFRAME(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, > _PIPEAFRAMEHIGH) > #define PIPEFRAMEPIXEL(pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEAFRAMEPIXEL) > #define PIPESTAT(pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEASTAT) > > -- > 2.39.2 >
