> -----Original Message----- > From: Hogander, Jouni <[email protected]> > Sent: Friday, May 3, 2024 12:04 PM > To: [email protected] > Cc: Manna, Animesh <[email protected]>; Hogander, Jouni > <[email protected]> > Subject: [PATCH v9 03/12] drm/i915/dp: Use always vsc revision 0x6 for Panel > Replay > > We are about to enable Panel Replay Selective update mode. Vsc revision 0x6 > for Panel Replay no matter if it is selective update or full frame update > mode. > Take this into account when preparing VSC SDP package. > > Signed-off-by: Jouni Högander <[email protected]>
Reviewed-by: Animesh Manna <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index 0755bdfc8d3d..5731aa84992e 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2660,14 +2660,6 @@ static void intel_dp_compute_vsc_sdp(struct > intel_dp *intel_dp, > if (intel_dp_needs_vsc_sdp(crtc_state, conn_state)) { > intel_dp_compute_vsc_colorimetry(crtc_state, conn_state, > vsc); > - } else if (crtc_state->has_sel_update) { > - /* > - * [PSR2 without colorimetry] > - * Prepare VSC Header for SU as per eDP 1.4 spec, Table 6-11 > - * 3D stereo + PSR/PSR2 + Y-coordinate. > - */ > - vsc->revision = 0x4; > - vsc->length = 0xe; > } else if (crtc_state->has_panel_replay) { > /* > * [Panel Replay without colorimetry info] @@ -2676,6 > +2668,14 @@ static void intel_dp_compute_vsc_sdp(struct intel_dp > *intel_dp, > */ > vsc->revision = 0x6; > vsc->length = 0x10; > + } else if (crtc_state->has_sel_update) { > + /* > + * [PSR2 without colorimetry] > + * Prepare VSC Header for SU as per eDP 1.4 spec, Table 6-11 > + * 3D stereo + PSR/PSR2 + Y-coordinate. > + */ > + vsc->revision = 0x4; > + vsc->length = 0xe; > } else { > /* > * [PSR1] > -- > 2.34.1
