On Mon, 11 Dec 2023, Ankit Nautiyal <[email protected]> wrote: > Avoid checking for Downstream Facing Port capabilities, > if its not a DP branch device.
Why? The commit message *always* needs to answer the question why. This commit message describes what the patch does in English. BR, Jani. > > Signed-off-by: Ankit Nautiyal <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index 3b2482bf683f..bef797b63000 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5502,6 +5502,9 @@ intel_dp_update_dfp(struct intel_dp *intel_dp, > struct drm_i915_private *i915 = dp_to_i915(intel_dp); > struct intel_connector *connector = intel_dp->attached_connector; > > + if (!drm_dp_is_branch(intel_dp->dpcd)) > + return; > + > intel_dp->dfp.max_bpc = > drm_dp_downstream_max_bpc(intel_dp->dpcd, > intel_dp->downstream_ports, drm_edid); -- Jani Nikula, Intel
