> -----Original Message----- > From: Intel-gfx <[email protected]> On Behalf Of Ville > Syrjala > Sent: Friday, November 24, 2023 10:28 AM > To: [email protected] > Subject: [Intel-gfx] [PATCH 2/5] drm/i915: Replace a memset() with zero > initialization > > From: Ville Syrjälä <[email protected]> > > Declaring a struct and immediately zeroing it with memset() seems a bit silly > to me. Just zero initialize the struct when declaring it. >
Reviewed-by: Mika Kahola <[email protected]> > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > index ef57dad1a9cb..0376adc36780 100644 > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > @@ -4465,12 +4465,10 @@ verify_single_dpll_state(struct drm_i915_private > *i915, > struct intel_crtc *crtc, > const struct intel_crtc_state *new_crtc_state) { > - struct intel_dpll_hw_state dpll_hw_state; > + struct intel_dpll_hw_state dpll_hw_state = {}; > u8 pipe_mask; > bool active; > > - memset(&dpll_hw_state, 0, sizeof(dpll_hw_state)); > - > drm_dbg_kms(&i915->drm, "%s\n", pll->info->name); > > active = intel_dpll_get_hw_state(i915, pll, &dpll_hw_state); > -- > 2.41.0
