On Tue, Oct 24, 2023 at 9:17 PM Ville Syrjala <[email protected]> wrote: > > From: Ville Syrjälä <[email protected]> > > Before the refactoring the pr_warn() only triggered when > someone explicitly tried to write to a BIOS locked limit. > After the refactoring the warning is also triggering during > system resume. The user can't do anything about this so > printing scary warnings doesn't make sense > > Keep the printk but make it pr_debug() instead of pr_warn() > to make it clear it's not a serious issue. > > Cc: Zhang Rui <[email protected]> > Cc: Wang Wendy <[email protected]> > Cc: Rafael J. Wysocki <[email protected]> > Cc: Srinivas Pandruvada <[email protected]> > Fixes: 9050a9cd5e4c ("powercap: intel_rapl: Cleanup Power Limits support") > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/powercap/intel_rapl_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/powercap/intel_rapl_common.c > b/drivers/powercap/intel_rapl_common.c > index 40a2cc649c79..2feed036c1cd 100644 > --- a/drivers/powercap/intel_rapl_common.c > +++ b/drivers/powercap/intel_rapl_common.c > @@ -892,7 +892,7 @@ static int rapl_write_pl_data(struct rapl_domain *rd, int > pl, > return -EINVAL; > > if (rd->rpl[pl].locked) { > - pr_warn("%s:%s:%s locked by BIOS\n", rd->rp->name, rd->name, > pl_names[pl]); > + pr_debug("%s:%s:%s locked by BIOS\n", rd->rp->name, rd->name, > pl_names[pl]); > return -EACCES; > } > > --
Applied, thanks!
