> -----Original Message-----
> From: Shankar, Uma
> Sent: Monday, October 9, 2023 3:06 PM
> To: Borah, Chaitanya Kumar <[email protected]>; intel-
> [email protected]
> Cc: Manna, Animesh <[email protected]>
> Subject: RE: [PATCH] drm/i915: Add wrapper for getting display step
>
>
>
> > -----Original Message-----
> > From: Borah, Chaitanya Kumar <[email protected]>
> > Sent: Tuesday, October 3, 2023 12:22 PM
> > To: [email protected]
> > Cc: Shankar, Uma <[email protected]>; Borah, Chaitanya Kumar
> > <[email protected]>; Manna, Animesh
> > <[email protected]>
> > Subject: [PATCH] drm/i915: Add wrapper for getting display step
> >
> > Add a wrapper around intel_step_name that takes in driver data as an
> argument.
> > This wrapper will help maintain compatibility with the proposed xe driver.
>
> Looks Good to me.
> Reviewed-by: Uma Shankar <[email protected]>
Pushed to drm-intel-next. Thanks for the patch.
Regards,
Uma Shankar
> > Signed-off-by: Chaitanya Kumar Borah <[email protected]>
> > Signed-off-by: Animesh Manna <[email protected]>
> > ---
> > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +-
> > drivers/gpu/drm/i915/intel_step.c | 5 +++++
> > drivers/gpu/drm/i915/intel_step.h | 1 +
> > 3 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> > b/drivers/gpu/drm/i915/display/intel_dmc.c
> > index 1623c0c5e8a1..63e080e07023 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> > @@ -309,7 +309,7 @@ static const struct stepping_info *
> > intel_get_stepping_info(struct drm_i915_private *i915,
> > struct stepping_info *si)
> > {
> > - const char *step_name = intel_step_name(RUNTIME_INFO(i915)-
> > >step.display_step);
> > + const char *step_name = intel_display_step_name(i915);
> >
> > si->stepping = step_name[0];
> > si->substepping = step_name[1];
> > diff --git a/drivers/gpu/drm/i915/intel_step.c
> > b/drivers/gpu/drm/i915/intel_step.c
> > index ee4e5a2c0220..b4162f1be765 100644
> > --- a/drivers/gpu/drm/i915/intel_step.c
> > +++ b/drivers/gpu/drm/i915/intel_step.c
> > @@ -353,3 +353,8 @@ const char *intel_step_name(enum intel_step step)
> > return "**";
> > }
> > }
> > +
> > +const char *intel_display_step_name(struct drm_i915_private *i915) {
> > + return intel_step_name(RUNTIME_INFO(i915)->step.display_step);
> > +}
> > diff --git a/drivers/gpu/drm/i915/intel_step.h
> > b/drivers/gpu/drm/i915/intel_step.h
> > index 96dfca4cba73..b6f43b624774 100644
> > --- a/drivers/gpu/drm/i915/intel_step.h
> > +++ b/drivers/gpu/drm/i915/intel_step.h
> > @@ -78,5 +78,6 @@ enum intel_step {
> >
> > void intel_step_init(struct drm_i915_private *i915); const char
> > *intel_step_name(enum intel_step step);
> > +const char *intel_display_step_name(struct drm_i915_private *i915);
> >
> > #endif /* __INTEL_STEP_H__ */
> > --
> > 2.25.1
