> From: Tian, Kevin <[email protected]> > Sent: Thursday, April 27, 2023 2:36 PM > > > From: Liu, Yi L <[email protected]> > > Sent: Wednesday, April 26, 2023 10:54 PM > > > > -static inline bool vfio_device_is_noiommu(struct vfio_device *vdev) > > +static inline int vfio_device_set_noiommu(struct vfio_device *device) > > { > > - return IS_ENABLED(CONFIG_VFIO_NOIOMMU) && > > - vdev->group->type == VFIO_NO_IOMMU; > > + device->noiommu = IS_ENABLED(CONFIG_VFIO_NOIOMMU) && > > + device->group->type == VFIO_NO_IOMMU; > > + return 0; > > Just void. this can't fail.
Hmmm. Yes, before below commit, it cannot fail. Maybe this can be converted to int later. https://lore.kernel.org/kvm/[email protected]/T/#u Regards, Yi Liu
