Hi John,
> Dan Carpenter pointed out that 'err' was not being set in the case
> where the GuC firmware version range check fails. Fix that.
>
> Note that while this is bug fix for a previous patch (see Fixes tag
is _a_ bug fix.
> below). It is an exceedingly low risk bug. The range check is
> asserting that the GuC firmware version is within spec. So it should
> not be possible to ever have a firmware file that fails this check. If
> larger version numbers are required in the future, that would be a
> backwards breaking spec change and thus require a major version bump,
> in which case an old i915 driver would not load that new version anyway.
>
> Fixes: 9bbba0667f37 ("drm/i915/guc: Use GuC submission API version number")
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: John Harrison <[email protected]>
> Cc: John Harrison <[email protected]>
> Cc: Daniele Ceraolo Spurio <[email protected]>
> Cc: Alan Previn <[email protected]>
> Cc: Umesh Nerlige Ramappa <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Matthew Brost <[email protected]>
> Cc: Andi Shyti <[email protected]>
> Cc: Matthew Auld <[email protected]>
> Cc: Tvrtko Ursulin <[email protected]>
> Cc: Lucas De Marchi <[email protected]>
> Cc: Jani Nikula <[email protected]>
Reviewed-by: Andi Shyti <[email protected]>
Andi
