> From: Jason Gunthorpe <[email protected]> > Sent: Thursday, March 30, 2023 7:52 PM > > On Thu, Mar 30, 2023 at 07:09:31AM +0000, Liu, Yi L wrote: > > > > > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df, > > > > + struct vfio_device_bind_iommufd > > > > __user *arg) > > > > +{ > > > > + struct vfio_device *device = df->device; > > > > + struct vfio_device_bind_iommufd bind; > > > > + struct iommufd_ctx *iommufd = NULL; > > > > + unsigned long minsz; > > > > + int ret; > > > > + > > > > + static_assert(__same_type(arg->out_devid, bind.out_devid)); > > > > > > They're the same field in the same structure, how could they be > > > otherwise? > > > > @Jason, should I remove this check? > > Yes, it was from something that looked very different from this
ok, I'll remove it here and next patch. 😊
