On Thu, Dec 12, 2013 at 03:00:42PM +0200, Imre Deak wrote: > On Fri, 2013-11-29 at 14:01 +0000, Chris Wilson wrote: > > On Thu, Nov 28, 2013 at 05:29:57PM +0200, [email protected] > > wrote: > > > From: Ville Syrjälä <[email protected]> > > > > > > Gen2 and gen3 don't have the FBC_CONTROL2 register, so don't > > > touch it. > > > > > > Signed-off-by: Ville Syrjälä <[email protected]> > > > > Hmm, another instance in i915_suspend.c > > Ville said he'll follow up with a separate fix for that, so:
Imo the right fix for that code is to disable it for modeset drivers and make sure we restore everything in the normal modeset paths. There's very little gunk left in there that we actually need, so every time we touch this we should make some forward progress to it's ultimate demise. -Daniel > Reviewed-by: Imre Deak <[email protected]> > > > -Chris > > > > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
