On Tue, Jun 07, 2022 at 04:15:42PM +0530, Anshuman Gupta wrote:
> i915 must disable Render DOP clock gating globally.
> 
> v2:
> - Addressed cosmetic review comments.
> 
> Bspec: 52621
> Cc: Matt Roper <[email protected]>
> Cc: Badal Nilawar <[email protected]>
> Signed-off-by: Anshuman Gupta <[email protected]>

Reviewed-by: Matt Roper <[email protected]>

> ---
>  drivers/gpu/drm/i915/gt/intel_gt_regs.h     | 1 +
>  drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h 
> b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> index 6aa1ceaa8d27..c8129a351731 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> @@ -631,6 +631,7 @@
>  
>  #define GEN7_MISCCPCTL                               _MMIO(0x9424)
>  #define   GEN7_DOP_CLOCK_GATE_ENABLE         (1 << 0)
> +#define   GEN12_DOP_CLOCK_GATE_RENDER_ENABLE REG_BIT(1)
>  #define   GEN8_DOP_CLOCK_GATE_CFCLK_ENABLE   (1 << 2)
>  #define   GEN8_DOP_CLOCK_GATE_GUC_ENABLE     (1 << 4)
>  #define   GEN8_DOP_CLOCK_GATE_MEDIA_ENABLE   (1 << 6)
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c 
> b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 6e875d4f5f65..1e7ca3863f20 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1486,6 +1486,9 @@ dg2_gt_workarounds_init(struct intel_gt *gt, struct 
> i915_wa_list *wal)
>        * performance guide section.
>        */
>       wa_write_or(wal, GEN12_SQCM, EN_32B_ACCESS);
> +
> +     /* Wa_14015795083 */
> +     wa_write_clr(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE);
>  }
>  
>  static void
> -- 
> 2.26.2
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation

Reply via email to