Hi Mauro, I love your patch! Yet something to improve:
[auto build test ERROR on mcgrof/modules-next] [also build test ERROR on linus/master v5.18-rc4 next-20220429] [cannot apply to tiwai-sound/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mauro-Carvalho-Chehab/Let-userspace-know-when-snd-hda-intel-needs-i915/20220430-214332 base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next config: riscv-buildonly-randconfig-r003-20220428 (https://download.01.org/0day-ci/archive/20220501/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 400775649969b9baf3bc2a510266e7912bb16ae9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/32f6557b5cc77c3cc2fcf6e68f11d989e31c954d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Let-userspace-know-when-snd-hda-intel-needs-i915/20220430-214332 git checkout 32f6557b5cc77c3cc2fcf6e68f11d989e31c954d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash sound/hda/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): >> sound/hda/hdac_component.c:202:7: error: call to undeclared function >> '__try_module_get'; ISO C99 and later do not support implicit function >> declarations [-Wimplicit-function-declaration] if (!__try_module_get(acomp->ops->owner, dev->driver->owner)) { ^ sound/hda/hdac_component.c:202:7: note: did you mean 'try_module_get'? include/linux/module.h:759:20: note: 'try_module_get' declared here static inline bool try_module_get(struct module *module) ^ 1 error generated. vim +/__try_module_get +202 sound/hda/hdac_component.c 183 184 static int hdac_component_master_bind(struct device *dev) 185 { 186 struct drm_audio_component *acomp = hdac_get_acomp(dev); 187 int ret; 188 189 if (WARN_ON(!acomp)) 190 return -EINVAL; 191 192 ret = component_bind_all(dev, acomp); 193 if (ret < 0) 194 return ret; 195 196 if (WARN_ON(!(acomp->dev && acomp->ops))) { 197 ret = -EINVAL; 198 goto out_unbind; 199 } 200 201 /* pin the module to avoid dynamic unbinding, but only if given */ > 202 if (!__try_module_get(acomp->ops->owner, dev->driver->owner)) { 203 ret = -ENODEV; 204 goto out_unbind; 205 } 206 207 if (acomp->audio_ops && acomp->audio_ops->master_bind) { 208 ret = acomp->audio_ops->master_bind(dev, acomp); 209 if (ret < 0) 210 goto module_put; 211 } 212 213 complete_all(&acomp->master_bind_complete); 214 return 0; 215 216 module_put: 217 module_put(acomp->ops->owner); 218 out_unbind: 219 component_unbind_all(dev, acomp); 220 complete_all(&acomp->master_bind_complete); 221 222 return ret; 223 } 224 -- 0-DAY CI Kernel Test Service https://01.org/lkp
