Thanks again for the detailed review here.
Will fix all the rest on next rev.
One special response for this one:
On Tue, 2021-12-07 at 16:22 -0800, Matthew Brost wrote:
> On Mon, Nov 22, 2021 at 03:04:02PM -0800, Alan Previn wrote:
> > + if (datatype == GUC_CAPTURE_LIST_TYPE_ENGINE_INSTANCE) {
> > + GCAP_PRINT_GUC_INST_INFO(i915, ebuf, data);
> > + eng_inst =
> > FIELD_GET(GUC_CAPTURE_DATAHDR_SRC_INSTANCE, data.info);
> > + eng = guc_lookup_engine(guc, engineclass,
> > eng_inst);
> > + if (eng) {
> > + GCAP_PRINT_INTEL_ENG_INFO(i915, ebuf,
> > eng);
> > + } else {
> > + PRINT(&i915->drm, ebuf, "
> > i915-Eng-Lookup Fail!\n");
> > + }
> > + ce = guc_context_lookup(guc, data.guc_ctx_id);
>
> You are going to need to reference count the 'ce' here. See
> intel_guc_context_reset_process_msg for an example.
>
Oh crap - i missed this one - which you had explicitly mentioned offline when i
was doing the
development. Sorry about that i just totally missed it from my todo-notes.
...alan
