> -----Original Message-----
> From: Vivi, Rodrigo <[email protected]>
> Sent: Friday, September 10, 2021 11:15 PM
> To: [email protected]
> Cc: Vivi, Rodrigo <[email protected]>; Daniel Vetter
> <[email protected]>; David Weinehall <[email protected]>;
> Tangudu, Tilak <[email protected]>; Deak, Imre <[email protected]>;
> Gupta, Anshuman <[email protected]>
> Subject: [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default
>
> Let's enable runtime pm autosuspend by default everywhere.
>
> But at this time let's not touch the autosuspend_delay time, what caused some
> regression on our previous attempt.
>
> v2: CI on some gen9 platforms was not clean. But it came
> pretty clean on newer generations. For now, let's
> pick gen12 and newer. We will return later to extend
> that to older platforms.
>
> Cc: Daniel Vetter <[email protected]>
> Cc: David Weinehall <[email protected]>
> Cc: Tilak Tangudu <[email protected]>
> Cc: Imre Deak <[email protected]>
> Signed-off-by: Rodrigo Vivi <[email protected]>
> Reviewed-by: Anshuman Gupta <[email protected]> #v1
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index f28b5bab61b4..f91a04c3ef14 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -605,6 +605,10 @@ void intel_runtime_pm_enable(struct
> intel_runtime_pm *rpm)
> pm_runtime_use_autosuspend(kdev);
> }
>
> + /* XXX: Enable by default only for newer platforms for now */
> + if (GRAPHICS_VER(i915) >= 12)
> + pm_runtime_allow(kdev);
Reviewed-by: Anshuman Gupta <[email protected]>
Looks good to me.
Br,
Anshuman Gupta.
> +
> /*
> * The core calls the driver load handler with an RPM reference held.
> * We drop that here and will reacquire it during unloading in
> --
> 2.31.1
