On Fri, Jul 9, 2021 at 2:12 PM Anshuman Gupta <[email protected]> wrote:
>
> Extend i915_lpsp_capability sysfs to xelpd and future platforms.

You're talking about sysfs but the patch is toucing a _debugfs.c file.
Something is very, very wrong here, either the commit message, or
worse, the code that's there already.

If this is indeed sysfs it must be split out asap, and ideally also
documented and all that, because sysfs is uapi.
-Daniel

>
> Cc: Animesh Manna <[email protected]>
> Signed-off-by: Anshuman Gupta <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c 
> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index af9e58619667..75d991a0707e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2255,6 +2255,11 @@ static int i915_lpsp_capability_show(struct seq_file 
> *m, void *data)
>         if (connector->status != connector_status_connected)
>                 return -ENODEV;
>
> +       if (DISPLAY_VER(i915) >= 13) {
> +               LPSP_CAPABLE(encoder->port <= PORT_B);
> +               return 0;
> +       }
> +
>         switch (DISPLAY_VER(i915)) {
>         case 12:
>                 /*
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to