> -----Original Message-----
> From: Intel-gfx <[email protected]> On Behalf Of Jani 
> Nikula
> Sent: Thursday, February 11, 2021 8:22 PM
> To: [email protected]
> Cc: Nikula, Jani <[email protected]>; Varide, Nischal 
> <[email protected]>
> Subject: [Intel-gfx] [PATCH v3 2/9] drm/i915/edp: reject modes with dimensions
> other than fixed mode
> 
> Be more strict about filtering modes for eDP.
> 
> Cc: Nischal Varide <[email protected]>
> Signed-off-by: Jani Nikula <[email protected]>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4f89e0de5dde..169b44c8ebbc 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -789,10 +789,10 @@ intel_dp_mode_valid(struct drm_connector *connector,
>               return MODE_H_ILLEGAL;
> 
>       if (intel_dp_is_edp(intel_dp) && fixed_mode) {
> -             if (mode->hdisplay > fixed_mode->hdisplay)
> +             if (mode->hdisplay != fixed_mode->hdisplay)
>                       return MODE_PANEL;

Looks fine as we practically will not have panels with multiple resolutions 
except maybe mode with varying
refresh rate incase of DRRS panels. But hdisplay and vdisplay will still remain 
same.

Reviewed-by: Uma Shankar <[email protected]>

> -             if (mode->vdisplay > fixed_mode->vdisplay)
> +             if (mode->vdisplay != fixed_mode->vdisplay)
>                       return MODE_PANEL;
> 
>               target_clock = fixed_mode->clock;
> --
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to