Quoting Michał Winiarski (2020-07-06 11:49:52) > From: Michał Winiarski <[email protected]> > > Getting wedged device on driver init is pretty much unrecoverable. > Since we're running various scenarios that may potentially hit this in > CI (module reload / selftests / hotunplug), and if it happens, it means > that we can't trust any subsequent CI results, we should just apply the > taint to let the CI know that it should reboot (CI checks taint between > test runs). > > v2: Comment that WEDGED_ON_INIT is non-recoverable, distinguish > WEDGED_ON_INIT from WEDGED_ON_FINI (Chris) > > Signed-off-by: Michał Winiarski <[email protected]> > Cc: Chris Wilson <[email protected]> > Cc: Michal Wajdeczko <[email protected]> > Cc: Petri Latvala <[email protected]>
+1 for has_unrecoverable_error() Reviewed-by: Chris Wilson <[email protected]> > -static inline bool intel_gt_has_init_error(const struct intel_gt *gt) > +static inline bool intel_gt_is_wedged(const struct intel_gt *gt) > { > - return test_bit(I915_WEDGED_ON_INIT, >->reset.flags); > + GEM_BUG_ON(intel_gt_has_unrecoverable_error(gt) ? > + !test_bit(I915_WEDGED, >->reset.flags) : false); GEM_BUG_ON(intel_gt_has_unrecoverable_error(gt) && !test_bit(I915_WEDGED, >->reset.flags)); Perhaps a bit more conventional way of saying the same :) -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
