Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20200423]
[cannot apply to v5.7-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gt-Prefer-soft-rc6-over-RPS-DOWN_TIMEOUT/20200423-004717
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a002-20200423 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <[email protected]>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/gt/intel_rps.c: In function 'rps_enable_interrupts':
>> drivers/gpu/drm/i915/gt/intel_rps.c:73:6: error: unused variable 'events' 
>> [-Werror=unused-variable]
     u32 events;
         ^
   cc1: all warnings being treated as errors

vim +/events +73 drivers/gpu/drm/i915/gt/intel_rps.c

3e7abf8141935d Andi Shyti   2019-10-24  69  
3e7abf8141935d Andi Shyti   2019-10-24  70  static void 
rps_enable_interrupts(struct intel_rps *rps)
3e7abf8141935d Andi Shyti   2019-10-24  71  {
3e7abf8141935d Andi Shyti   2019-10-24  72      struct intel_gt *gt = 
rps_to_gt(rps);
408464b4cbcf0a Chris Wilson 2020-03-11 @73      u32 events;
3e7abf8141935d Andi Shyti   2019-10-24  74  
3e7abf8141935d Andi Shyti   2019-10-24  75      rps_reset_ei(rps);
3e7abf8141935d Andi Shyti   2019-10-24  76  
3e7abf8141935d Andi Shyti   2019-10-24  77      spin_lock_irq(&gt->irq_lock);
3e7abf8141935d Andi Shyti   2019-10-24  78      gen6_gt_pm_enable_irq(gt, 
rps->pm_events);
3e7abf8141935d Andi Shyti   2019-10-24  79      spin_unlock_irq(&gt->irq_lock);
3e7abf8141935d Andi Shyti   2019-10-24  80  
a080bd994c4023 Chris Wilson 2020-04-15  81      intel_uncore_write(gt->uncore,
a080bd994c4023 Chris Wilson 2020-04-15  82                         
GEN6_PMINTRMSK, rps_pm_mask(rps, rps->last_freq));
3e7abf8141935d Andi Shyti   2019-10-24  83  }
3e7abf8141935d Andi Shyti   2019-10-24  84  

:::::: The code at line 73 was first introduced by commit
:::::: 408464b4cbcf0a22ea8f96dab15d87a2f43ffed7 drm/i915/gt: Pull checking 
rps->pm_events under the irq_lock

:::::: TO: Chris Wilson <[email protected]>
:::::: CC: Chris Wilson <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to