> -----Original Message----- > From: Maarten Lankhorst <[email protected]> > Sent: Thursday, March 26, 2020 4:18 PM > To: Shankar, Uma <[email protected]>; [email protected] > Cc: Ville Syrjä <[email protected]>; Kai Vehmanen > <[email protected]>; Souza, Jose <[email protected]>; Khor, Swee > Aun <[email protected]> > Subject: Re: [PATCH] drm/i915/display: Fix mode private_flags comparison at > atomic_check > > Op 26-03-2020 om 08:49 schreef Uma Shankar: > > This patch fixes the private_flags of mode to be checked and compared > > against uapi.mode and not from hw.mode. This helps properly trigger > > modeset at boot if desired by driver. > > > > It helps resolve audio_codec initialization issues if display is > > connected at boot. Initial discussion on this issue has happened on > > below thread: > > https://patchwork.freedesktop.org/series/74828/ > > > > Fixes: https://gitlab.freedesktop.org/drm/intel/issues/1363 > > Wrong use of fixes. :) > > Use dim fixes original-commit-id to reference the commit. And for this use the > Closes: tag. > > Other than that looks good. :) > > So with headers fixed:
Thanks for the feedback Maarten. Floated v2 with this updated. Regards, Uma Shankar > Reviewed-By: Maarten Lankhorst <[email protected]> > > > Cc: Ville Syrjä <[email protected]> > > Cc: Maarten Lankhorst <[email protected]> > > Cc: Kai Vehmanen <[email protected]> > > Cc: Souza, Jose <[email protected]> > > Suggested-by: Ville Syrjä <[email protected]> > > Signed-off-by: Uma Shankar <[email protected]> > > Signed-off-by: SweeAun Khor <[email protected]> > > --- > > drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > > b/drivers/gpu/drm/i915/display/intel_display.c > > index fe55c7c713f1..e630429af2c0 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -14747,8 +14747,8 @@ static int intel_atomic_check(struct drm_device > > *dev, > > /* Catch I915_MODE_FLAG_INHERITED */ > > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, > > new_crtc_state, i) { > > - if (new_crtc_state->hw.mode.private_flags != > > - old_crtc_state->hw.mode.private_flags) > > + if (new_crtc_state->uapi.mode.private_flags != > > + old_crtc_state->uapi.mode.private_flags) > > new_crtc_state->uapi.mode_changed = true; > > } > > > _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
