> -----Original Message----- > From: Intel-gfx <[email protected]> On Behalf Of Gwan- > gyeong Mun > Sent: Monday, February 10, 2020 10:40 PM > To: [email protected] > Cc: [email protected]; [email protected] > Subject: [Intel-gfx] [PATCH v6 14/18] drm/i915: Fix enabled infoframe states > of > lspcon > > Compared to implementation of DP and HDMI's encoder->infoframes_enabled, the > lspcon's implementation returns its active state. (we expect enabled infoframe > states of HW.) It leads to pipe state mismatch error when ddi_get_config is > called. > > Because the current implementation of lspcon is not ready to support readout > infoframes, we need to return 0 here. > > In order to support readout to lspcon, we need to implement read_infoframe and > infoframes_enabled. And set_infoframes also have to set an appropriate bit on > crtc_state->infoframes.enable
Looks good to me. Reviewed-by: Uma Shankar <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Signed-off-by: Gwan-gyeong Mun <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c > b/drivers/gpu/drm/i915/display/intel_lspcon.c > index d807c5648c87..6ff7b226f0a1 100644 > --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > @@ -522,7 +522,7 @@ u32 lspcon_infoframes_enabled(struct intel_encoder > *encoder, > const struct intel_crtc_state *pipe_config) { > /* FIXME actually read this from the hw */ > - return enc_to_intel_lspcon(encoder)->active; > + return 0; > } > > void lspcon_resume(struct intel_lspcon *lspcon) > -- > 2.25.0 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
