On Tue, Mar 03, 2020 at 06:23:47AM -0800, Aditya Swarup wrote: > Static code analysis tool identified struct lrc_timestamp data as being > uninitialized and then data.ce[] is being checked for NULL/negative > value in the error path. Initializing data variable fixes the issue. > > Cc: Matt Roper <[email protected]> > Cc: Chris Wilson <[email protected]> > Signed-off-by: Aditya Swarup <[email protected]>
Reviewed-by: Matt Roper <[email protected]> > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c > b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index ccf9debacd90..9b75b3c77a5b 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -4725,7 +4725,7 @@ static int live_lrc_timestamp(void *arg) > { > struct intel_gt *gt = arg; > enum intel_engine_id id; > - struct lrc_timestamp data; > + struct lrc_timestamp data = { 0 }; > const u32 poison[] = { > 0, > S32_MAX, > -- > 2.25.0 > -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
