On Thu, Jan 23, 2020 at 12:59:34PM +0000, Chris Wilson wrote: > To multiply 2 u32 numbers to generate a u64 in C requires a bit of > forewarning for the compiler. > > Signed-off-by: Chris Wilson <[email protected]> > Cc: Ramalingam C <[email protected]> > Cc: Joonas Lahtinen <[email protected]> > Cc: [email protected] > --- > drivers/gpu/drm/i915/i915_gem.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 0a20083321a3..ff79da5657f8 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -265,7 +265,10 @@ i915_gem_dumb_create(struct drm_file *file, > DRM_FORMAT_MOD_LINEAR)) > args->pitch = ALIGN(args->pitch, 4096); > > - args->size = args->pitch * args->height; > + if (args->pitch < args->width) > + return -EINVAL; > + > + args->size = mul_u32_u32(args->pitch, args->height);
I thought something would have checked these against the mode_config fb limits already. But can't see code like that anywhere. Maybe we should just do that in the core? > > mem_type = INTEL_MEMORY_SYSTEM; > if (HAS_LMEM(to_i915(dev))) > -- > 2.25.0 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
