On 2020.01.22 20:10:24 +0000, Igor Druzhinin wrote: > If the module happens to be loaded later at runtime there is a chance > memory is already fragmented enough to fail allocation of firmware > blob storage and consequently GVT init. Since it doesn't seem to be > necessary to have the blob contiguous, use vmalloc() instead to avoid > the issue. > > Signed-off-by: Igor Druzhinin <[email protected]> > --- > drivers/gpu/drm/i915/gvt/firmware.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/firmware.c > b/drivers/gpu/drm/i915/gvt/firmware.c > index 049775e..b0c1fda 100644 > --- a/drivers/gpu/drm/i915/gvt/firmware.c > +++ b/drivers/gpu/drm/i915/gvt/firmware.c > @@ -146,7 +146,7 @@ void intel_gvt_free_firmware(struct intel_gvt *gvt) > clean_firmware_sysfs(gvt); > > kfree(gvt->firmware.cfg_space); > - kfree(gvt->firmware.mmio); > + vfree(gvt->firmware.mmio); > } > > static int verify_firmware(struct intel_gvt *gvt, > @@ -229,7 +229,7 @@ int intel_gvt_load_firmware(struct intel_gvt *gvt) > > firmware->cfg_space = mem; > > - mem = kmalloc(info->mmio_size, GFP_KERNEL); > + mem = vmalloc(info->mmio_size); > if (!mem) { > kfree(path); > kfree(firmware->cfg_space); > -- > 2.7.4 >
Looks fine to me. Thanks! Reviewed-by: Zhenyu Wang <[email protected]> -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
signature.asc
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
