For commit dc93c9b69315 ("drm/i915/gt: Schedule request retirement when
signaler idles") we added the intel_engine_init_retire() to the virtual
engine, but since it does not use the common cleanup routine, we need to
also add the intel_engine_fini_retire() to flush the retirement worker
before freeing.

Fixes: dc93c9b69315 ("drm/i915/gt: Schedule request retirement when signaler 
idles")
Signed-off-by: Chris Wilson <[email protected]>
Cc: Tvrtko Ursulin <[email protected]>
Cc: Mika Kuoppala <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_lrc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c 
b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 56cf71d8bbda..3f6bbda4391e 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -4209,6 +4209,8 @@ static void virtual_context_destroy(struct kref *kref)
                __execlists_context_fini(&ve->context);
        intel_context_fini(&ve->context);
 
+       intel_engine_fini_retire(&ve->base);
+
        kfree(ve->bonds);
        kfree(ve);
 }
-- 
2.24.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to