On Mon, Dec 02, 2019 at 02:25:11PM -0800, José Roberto de Souza wrote: > If the CRTC is going from enabled to disabled and it is a port sync > slave, it needs to check to the old state to be disabled before the > port sync master.
Yes this makes sense, thank you for the fix Reviewed-by: Manasi navare <[email protected]> Manasi > > Cc: Manasi Navare <[email protected]> > Cc: Matt Roper <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Reviewed-by: Ville Syrjälä <[email protected]> > Signed-off-by: José Roberto de Souza <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index 1f1cd7578706..3062578e2bdb 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -14497,8 +14497,8 @@ static void intel_commit_modeset_disables(struct > intel_atomic_state *state) > * slave CRTCs are disabled first and then master CRTC since > * Slave vblanks are masked till Master Vblanks. > */ > - if (is_trans_port_sync_mode(new_crtc_state)) { > - if (is_trans_port_sync_master(new_crtc_state)) > + if (is_trans_port_sync_mode(old_crtc_state)) { > + if (is_trans_port_sync_master(old_crtc_state)) > intel_trans_port_sync_modeset_disables(state, > crtc, > > old_crtc_state, > -- > 2.24.0 > _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
