On Tue, 2019-06-04 at 17:58 +0300, Imre Deak wrote: > According to the spec we should not enable the DDI-IO power domain if > the TypeC port is in the TBT-alt mode, so do that only in the other > TypeC modes or for non-TypeC ports.
With: BSpec: 22243 Reviewed-by: José Roberto de Souza <[email protected]> > > Cc: Manasi Navare <[email protected]> > Cc: Anusha Srivatsa <[email protected]> > Signed-off-by: Imre Deak <[email protected]> > --- > drivers/gpu/drm/i915/intel_ddi.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > b/drivers/gpu/drm/i915/intel_ddi.c > index a3574f14a3d0..8f223d48d562 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -3111,7 +3111,10 @@ static void intel_ddi_pre_enable_dp(struct > intel_encoder *encoder, > > intel_ddi_clk_select(encoder, crtc_state); > > - intel_display_power_get(dev_priv, dig_port- > >ddi_io_power_domain); > + if (!intel_port_is_tc(dev_priv, port) || > + dig_port->tc_mode != TC_PORT_TBT_ALT) > + intel_display_power_get(dev_priv, > + dig_port->ddi_io_power_domain); > > icl_program_mg_dp_mode(dig_port); > icl_disable_phy_clock_gating(dig_port); > @@ -3293,8 +3296,10 @@ static void intel_ddi_post_disable_dp(struct > intel_encoder *encoder, > intel_edp_panel_vdd_on(intel_dp); > intel_edp_panel_off(intel_dp); > > - intel_display_power_put_unchecked(dev_priv, > - dig_port- > >ddi_io_power_domain); > + if (!intel_port_is_tc(dev_priv, encoder->port) || > + dig_port->tc_mode != TC_PORT_TBT_ALT) > + intel_display_power_put_unchecked(dev_priv, > + dig_port- > >ddi_io_power_domain); > > intel_ddi_clk_disable(encoder); > } _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
