Quoting Ville Syrjala (2019-04-09 15:40:54)
> From: Ville Syrjälä <[email protected]>
>
> It's much easier to figure out why the SDVO encoder refuses to cooperate
> if we can see what status we got back.
>
> Signed-off-by: Ville Syrjälä <[email protected]>
> ---
> drivers/gpu/drm/i915/intel_sdvo.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
> b/drivers/gpu/drm/i915/intel_sdvo.c
> index d5a95eca23ba..5d928f6d0028 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -516,7 +516,7 @@ static bool intel_sdvo_read_response(struct intel_sdvo
> *intel_sdvo,
> u8 status;
> int i, pos = 0;
> #define BUF_LEN 256
> - char buffer[BUF_LEN];
> + char buffer[BUF_LEN] = {};
I should stop quibbling over a 256b memset.
> /*
> @@ -581,7 +581,8 @@ static bool intel_sdvo_read_response(struct intel_sdvo
> *intel_sdvo,
> return true;
>
> log_fail:
> - DRM_DEBUG_KMS("%s: R: ... failed\n", SDVO_NAME(intel_sdvo));
> + DRM_DEBUG_KMS("%s: R: ... failed %s\n",
> + SDVO_NAME(intel_sdvo), buffer);
Reviewed-by: Chris Wilson <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
