On 03/04/2019 08:13, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-04-03 07:44:07)
From: Tvrtko Ursulin <[email protected]>

Mask need to be initialized to zero since device id checks may not match.

Signed-off-by: Tvrtko Ursulin <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Fixes: 805446c8347c ("drm/i915: Introduce concept of a sub-platform")
Cc: Tvrtko Ursulin <[email protected]>
Cc: Chris Wilson <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Lucas De Marchi <[email protected]>
Cc: Jose Souza <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Cc: Paulo Zanoni <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Cc: Dan Carpenter <[email protected]>

Bots are doing a better job than me, but still
Reviewed-by: Chris Wilson <[email protected]>

It's my bad, probably introduced due various refactoring of the patch itself. Since I definitely remember changing the mask initialization back and forth.

No huge harm done since caught quickly by this very valuable service provided by Dan.

Regards,

Tvrtko

P.S. Also the assert about no junk in high bits did not fire in CI which would suggest stack slot was either zero or no more than three low bits sets. Strange luck.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to