On Thu, Jan 24, 2019 at 07:00:11PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > On Thu, Jan 24, 2019 at 05:58:14PM +0100, Daniel Vetter wrote: > > Should not result in any changes. > > > > Signed-off-by: Daniel Vetter <[email protected]> > > Cc: Dave Airlie <[email protected]> > > Cc: Junwei Zhang <[email protected]> > > Cc: Alex Deucher <[email protected]> > > Cc: "Christian König" <[email protected]> > > Cc: Daniel Vetter <[email protected]> > > Cc: Sean Paul <[email protected]> > > Cc: YueHaibing <[email protected]> > > Cc: Sam Bobroff <[email protected]> > > --- > > drivers/gpu/drm/ast/ast_drv.h | 2 +- > > drivers/gpu/drm/ast/ast_fb.c | 7 +------ > > 2 files changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h > > index bfc65040dfcb..ffce4608e0c5 100644 > > --- a/drivers/gpu/drm/ast/ast_drv.h > > +++ b/drivers/gpu/drm/ast/ast_drv.h > > @@ -259,7 +259,7 @@ struct ast_framebuffer { > > }; > > > > struct ast_fbdev { > > - struct drm_fb_helper helper; > > + struct drm_fb_helper helper; /* must be first */ > > Again in the category "I do not know the code", > but I failed to see whay "struct drm_fb_helper" have to be first. > > I saw no ugly cast or similar when browsign the code, but I > must have missed something?
It's casting the void *info->par to either struct ast_fbdev *(in ast code) or struct drm_fb_helper * (in fb helper code). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
