Hi 2013/2/9 Ben Widawsky <[email protected]>: > On Fri, 8 Feb 2013 17:35:14 -0200 > Paulo Zanoni <[email protected]> wrote: > >> From: Paulo Zanoni <[email protected]> >> >> Otherwise, if the BIOS did anything wrong, our first I915_{WRITE,READ} >> will give us "unclaimed register" messages. >> >> V2: Even earlier. >> >> Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=58897 >> Signed-off-by: Paulo Zanoni <[email protected]> > > I really wish we were allowed to call Haswell something like gen7.x, so > we can do INTEL_INFO(dev)->gen > 7
Like gen 70 and 75? > > Also, I would have cleared all the bits in the register, not just > NOCLAIM. I'm not so sure, the other bits have completely different purposes, unrelated with the "unclaimed registers". I don't think it's a good idea to zero bits that have nothing to do with the purpose of the code. > > Either way it's > Reviewed-by: Ben Widawsky <[email protected]> Thanks for the review :) > [snip] -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
