On Mon, Aug 27, 2018 at 03:37:53PM +0300, Juha-Pekka Heikkila wrote: > From gen11 onwards RGB565 90/270 plane rotation is supported on hardware. > > IGT: https://patchwork.freedesktop.org/series/48756/ > Signed-off-by: Juha-Pekka Heikkila <[email protected]> > --- > drivers/gpu/drm/i915/intel_atomic_plane.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c > b/drivers/gpu/drm/i915/intel_atomic_plane.c > index 344a16b..c245906 100644 > --- a/drivers/gpu/drm/i915/intel_atomic_plane.c > +++ b/drivers/gpu/drm/i915/intel_atomic_plane.c > @@ -123,14 +123,17 @@ static bool intel_plane_valid_rotation(const struct > drm_plane_state *plane_state > } > > /* > - * 90/270 is not allowed with RGB64 16:16:16:16, > - * RGB 16-bit 5:6:5, and Indexed 8-bit. > + * 90/270 is not allowed with RGB64 16:16:16:16 and > + * Indexed 8-bit. RGB 16-bit. 5:6:5 is allowed gen11 onwards. ^ Extra period there
Otherwise lgtm Reviewed-by: Ville Syrjälä <[email protected]> > * TBD: Add RGB64 case once its added in supported format > * list. > */ > switch (plane_state->fb->format->format) { > - case DRM_FORMAT_C8: > case DRM_FORMAT_RGB565: > + if (INTEL_GEN(dev_priv) >= 11) > + break; > + /* fall through */ > + case DRM_FORMAT_C8: > DRM_DEBUG_KMS("Unsupported pixel format %s for > 90/270!\n", > > drm_get_format_name(plane_state->fb->format->format, > &format_name)); > -- > 2.7.4 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
